Jump to content

Talk:Requests for comment/UserMailer refactor

Add topic
From mediawiki.org

April 9th update

[edit]

This RfC is due to be discussed briefly on April 9th; join us! Sharihareswara (WMF) (talk) 02:30, 8 April 2014 (UTC)Reply

Rough consensus is that we should refactor the interface to be cleaner, and probably use SwiftMailer as the new backend. Work on that is apparently ongoing. Expecting to decline this version of the rfc. --brion (talk) 22:08, 9 April 2014 (UTC)Reply
Thanks, Brion. User:Owyn, please take a look.
Full log of discussion:
22:01:20 <sumanah> #topic UserMailer refactor
22:01:25 <sumanah> #link https://www.mediawiki.org/wiki/Requests_for_comment/UserMailer_refactor by Owen Davis
22:01:35 <sumanah> #info Owen Davis last updated this in late 2013 and hasn't gotten any feedback.
22:01:35 <sumanah> #info Any objection to moving forward?
22:01:51 <brion> my main question about the usermailer refactor is whether the echo stuff duplicates/changes the email landscape
22:01:57 <sumanah> (it's such a short RfC, either it's simple or the RfC is too short)
22:02:01 <sumanah> #info <brion> my main question about the usermailer refactor is whether the echo stuff duplicates/changes the email landscape
22:02:12 <awight> I think it's a bad idea to pass the desired mailer class via the send() method.
22:02:20 <sumanah> #info <awight> I think it's a bad idea to pass the desired mailer class via the send() method.
22:02:28 <awight> abstracting the mailer is a great idea, however.
22:02:41 <MaxSem> I don't like the growing number of parameters to the static function, it's scary enough already
22:02:44 * awight reads http://wiki.debian.org/MeetBot.
22:02:46 <MaxSem> use OOP?
22:03:11 <sumanah> (these seem like things we ought to mention to Owen on the talkpage; I encourage anyone talking now to expand on their thoughts at https://www.mediawiki.org/wiki/Talk:Requests_for_comment/UserMailer_refactor )
22:03:30 <awight> agreed
22:03:31 <sumanah> (if they have any expansion on their thoughts)
22:03:36 <ebernhardson> personally, i find it really odd to even consider a mailer refactor before looking at the underlying mail system (such as Swift_Mailer mentioned in see also)
22:03:41 <MaxSem> and where's their code?
22:04:05 <sumanah> good question
22:04:05 <brion> yeah, it’s a bit light
22:04:36 <sumanah> parent5446: the end of http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-office/20140409.txt for the chat till now :)
22:04:36 <brion> now it seems the point of the rfc is ‘make it easier to merge the wikia changes’
22:04:45 <parent5446> sumanah: thanks
22:04:51 <brion> if that’s mostly ‘we have an extra class and adding these params makes it trivial to plug in’ then that’s probably spiffy
22:04:59 <MaxSem> I think this RFC should be declined
22:05:05 <ebernhardson> i agree
22:05:24 <brion> needs moar code
22:05:34 <MaxSem> a solution would be a class with eg function addAttachment(), not a huge parameter list
22:05:48 <ebernhardson> and those solutions already exist, we should just be chosing one
22:06:00 <parent5446> Keep in mind we have a GSoC project working on using SwiftMailer in core
22:06:13 <parent5446> That would fulfill most of the goals of this RFC
22:06:32 <brion> #info seems to be some agreement that using SwiftMailer as backend would resolve this better
22:06:39 <sumanah> so it sounds like someone should summarise this for the RfC talk page, or possibly we should just decline this
22:07:15 <brion> i’ll add a quick note
22:07:29 <sumanah> #action brion to summarise this discussion on RfC talk page (re user mailer)
Sharihareswara (WMF) (talk) 11:30, 10 April 2014 (UTC)Reply

Mailer componentization

[edit]

I think the extra parameters to send() are a bad idea because they actually increase code coupling, and break encapsulation. On the other hand, the prose description of changes sounds like a much better idea. Yes, we should abstract the mailer so that it is swappable with any compatible implementation. Adamw (talk) 22:05, 9 April 2014 (UTC)Reply

Looks like this RFC is going to be superseded by an integration of Swift Mailer, which would accomplish your suggestion. Owyn (talk) 21:11, 17 April 2014 (UTC)Reply