Jump to content

Talk:Heading HTML changes

Add topic
From mediawiki.org
Latest comment: 5 months ago by Matma Rex in topic Parsoid considerations

Parsoid considerations

[edit]

A few notes:

  1. The Parsoid team should probably be included on the critical path here, since the adoption of Parsoid read views, for at least some uses, is in the same critical time frame as the transition to the new heading HTML is given.
  2. Parsoid probably wants to transition the body content to a new div wrapper as well, so the overall structure is something like: <section><div><h2>....</h2>...</div><div>....body content...</div></section> -- so that section > *:first-child is always the heading and section > *:last-child is always the "content to be hidden for dynamic section display"; we'll probably want to add the extra wrapper around body content at the same time as the wrapper around heading content
  3. VisualEditor will of course need to be updated as well. Right now VE strips all the section wrapping that it receives from Parsoid. That approach could be extended, but eventually this means that the CSS for styling headings will start to look radically different "in VisualEditor" vs "in read views". It may be desirable to try to make the VE CE representation include (some of?) these wrappers as well, in order to ensure the CSS doesn't drift. That has complications during editing, however, like what if the heading is deleted merging two sections, or how do you keep the editor from adding text in the "wrong" place between the <section> and the <div>, etc.

cscott (talk) 16:53, 19 January 2023 (UTC)Reply

Parsing/Notes/Section Wrapping is the Parsoid spec for section wrapping, which should be updated.
Also gerrit 881732 / phab T289191 mentions section wrapping for literal <h2>/<h3>/etc tags in the wikitext. The same wrapping should apply for these tags as for other wikitext sections. cscott (talk) 23:35, 23 January 2023 (UTC)Reply
It's not clear to me from this page, is the output format for Parsoid HTML changing as well? The timeline says it happened in February 2024, but if I load, e.g. this page, I don't see mw-heading mw-heading2 classes. Legoktm (talk) 02:54, 8 June 2024 (UTC)Reply
Parsoid's canonical HTML was not changed, but Parsoid view mode HTML was. Try e.g. [1] to see it. Matma Rex (talk) 07:20, 8 June 2024 (UTC)Reply

Opting out

[edit]

Firstly, thank you for creating this page! "If you haven't had a chance to update your skin to style the new markup, a skin option is temporarily available to restore the old markup".

As an active skin developer (and often the one that handles deprecation warnings/complaints when skins are broken) it would be helpful to me if the default was "old markup" with a deprecation warning.

"a skin option is temporarily available to restore the old markup" suggests that when site admins update MediaWiki their skin will instantly break until they restore the old markup. I think it would be more helpful if for at least one release the skin worked with the old markup out of the box, but a deprecation warning pointed to this page, so that the issue would be as discoverable as possible and can be patched. We did something similar in preparation for https://phabricator.wikimedia.org/T306942 which took 2 releases to complete, and it was a lot of effort (mostly done by me) - so I see this as having very similar impact. Jdlrobson (talk) 21:04, 17 November 2023 (UTC)Reply

I think I could do that. Matma Rex (talk) 19:18, 27 November 2023 (UTC)Reply

Migrating IndexStyles/ TemplateStyles

[edit]

15 affected IndexStyles at English Wikisource:- [2]

What is the correct migration for these? ShakespeareFan00 (talk) 14:04, 29 April 2024 (UTC)Reply

Your search has some false matches, while excluding some heading levels, here's an improved query: [3]
Depending on the markup used on the page, either they won't need any changes, or selectors like h2 will need to become .mw-heading2 etc. Matma Rex (talk) 15:20, 29 April 2024 (UTC)Reply