Manual talk:Hooks/GetLocalURL::Internal

Called in the wrong place

I guess it's no good that the hook is being called after the url is put together. The $query argument is practically useless and the originally query parameters are already attached to the url you get in $url. This makes it less comfortable to actually modify the functions behavior with that hook. You have to wfAppendQuery() to add additional query parameters and you also can't easily check for existing query parameters since you have to parse the $url string for that. --Danwe (talk) 13:52, 29 June 2012 (UTC)