Jump to content

Extension talk:Checkpoint

Add topic
From mediawiki.org
Latest comment: 2 years ago by Pppery in topic fix extension

Hi, Thank you for your great extension. I have a small problem with your extension in my wiki which is running mediawiki 1.15.1. It works fine but when I install Extension:FlaggedRevs and approve the page as stable page, it does not work for further edits. Please let me know if any suggestions?


Use of "preview=yes" in query string

[edit]

This extension is ancient, so I don't know if I'll get any replies, but here goes...

The behavior of this (very useful) extension is strange in the latest MediaWiki versions (e.g., 1.28). When you click "Save and continue editing," the content does get saved, but the page refreshes and leaves you in preview mode. This is weird because right at the top of the previewed page is a note that says the page wasn't saved:

Remember that this is only a preview. Your changes have not yet been saved!

I would argue that the use of "preview=yes" in the URL query string, which is set in the function efCheckpointReturn, is no longer appropriate and should be changed as in this diff:

    if ( $frag == '' ) {
       // just append our query to the end
-      $url .= $querystr . 'action=edit&preview=yes';
+      $url .= $querystr . 'action=edit';
    } else {
       // do a string replace
-      $url = str_replace( $frag, $querystr . 'action=edit&preview=yes' . $frag, $url );
+      $url = str_replace( $frag, $querystr . 'action=edit' . $frag, $url );
    }

Any reason why this shouldn't be changed?

--Maiden taiwan (talk) 21:34, 4 January 2017 (UTC)Reply

This is normal behavior. Removing preview=yes would prevent the preview from appearing after hitting the button, if you have set in preferences that you don't want to display the preview just after hitting the edit link. preview=yes forces the preview appear on first hit of edit, even if in your preferences you doesn't have it. Example: [1]. This is probably worth a bugreport against MediaWiki core, not this extension, suggesting to split the message about the preview and the warning about changes aren't saved, because the warning should appear only after you hit preview changes and not on the first edit screen. --Ciencia Al Poder (talk) 10:35, 5 January 2017 (UTC)Reply

Unstable extension

[edit]

I installed this extension but when I wanted to use it it sent me to a blank page and it tells me that the site does not work, the extension install it on mediawiki 1.34 What do I do to make the extension work?--Uvas magicas (talk) 00:52, 31 December 2018 (UTC)Reply

MediaWiki 1.34 doesn't exist yet. To get a more meaningful error message, see blank page --Ciencia Al Poder (talk) 10:17, 31 December 2018 (UTC)Reply

fix extension

[edit]

hi, I was testing this extension and the only way to make it work in recent mediawiki is to do the following in the file "CheckpointHooks.php" remove the line:

$summary .= wfMessage( 'word-separator' )->text() . wfMessage( 'checkpoint-notice' )->text();

and to remove the preview is

in this line below change the "yes" to "no"

$url .= $querystr . 'action=edit&preview=yes';

--PetaloAzul (talk) 07:23, 6 February 2022 (UTC)Reply

@PetaloAzul: Please properly submit a patch to Gerrit. * Pppery * it has begun 20:52, 24 March 2022 (UTC)Reply